kasiazjc commented on PR #24449:
URL: https://github.com/apache/superset/pull/24449#issuecomment-1653777248
> > Sorry for the churn and delays on this, but I think the main issue is UI
design, not the technical implementation.
> > My own opinion: • It would be nice if it had the Select menu (including
the Custom option, rather than a button for Custom) • If (and only if) the
Custom option is selected from the Select menu, would the additional fields
appear (or disappear) • The Select menu would remain present... if you select
something other than Custom, the form elements are removed, and the values
ignored.
> > As a side note, I feel like the Submit button should be on the right,
and the cancel button on the left. I'm not sure if we have a solid documented
pattern around this, though (cc. @kasiazjc)
>
> Okay i will do some modification with UI.
Thanks and sorry for the long wait! What I'm thinking in terms of UI
improvements is this:
-> instead of button/switcher use single select, for selecting the type of
interval, the options are:
- don’t refresh
- custom interval (triggers the additional fields as shown below)
- all of the preset options that are available today (in the example
dropdown I listed only two, but should be all of them)
-> set fixed height for the modal to accommodate for disappearing custom
fields, so that the height does not jump
<img width="1108" alt="image"
src="https://github.com/apache/superset/assets/36897697/2bda1803-9e41-4306-83e1-ac29f8dc56d9";>
I think this way setting up the custom interval will be more intuitive, as
we are using common patterns. What do you think and could you possibly take
this up @Abhishek-kumar-samsung ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
