dungdm93 commented on code in PR #24913:
URL: https://github.com/apache/superset/pull/24913#discussion_r1288028040
##########
superset/db_engine_specs/trino.py:
##########
@@ -178,7 +191,7 @@ def prepare_cancel_query(cls, query: Query, session:
Session) -> None:
session.commit()
@classmethod
- def cancel_query(cls, cursor: Any, query: Query, cancel_query_id: str) ->
bool:
+ def cancel_query(cls, cursor: Cursor, query: Query, cancel_query_id: str)
-> bool:
Review Comment:
`Cursor` here is trino specific Cursor. `BaseEngineSpec` define cursor as
`Any` because each database driver has different `Cursor` class.
If's safe to be used here, see other methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
