dungdm93 commented on code in PR #24913:
URL: https://github.com/apache/superset/pull/24913#discussion_r1292813838
##########
superset/db_engine_specs/trino.py:
##########
@@ -188,11 +201,12 @@ def cancel_query(cls, cursor: Any, query: Query,
cancel_query_id: str) -> bool:
:return: True if query cancelled successfully, False otherwise
"""
try:
+ # Can't use cursor.cancel() because
+ # cursor is new object created in sql_lab.cancel_query
Review Comment:
Already has `return True` outside of try-catch block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
