john-bodley commented on code in PR #24984:
URL: https://github.com/apache/superset/pull/24984#discussion_r1294874313
##########
superset/db_engine_specs/hive.py:
##########
@@ -542,11 +542,9 @@ def update_impersonation_config(
connect_args["configuration"] = configuration
@staticmethod
- def execute( # type: ignore
- cursor, query: str, async_: bool = False
- ): # pylint: disable=arguments-differ
- kwargs = {"async": async_}
- cursor.execute(query, **kwargs)
+ def execute(cursor, query: str):
Review Comment:
@alldoami I don't believe this approach is correct as the `async_` keyword
argument is used by the PyHive DB-API
[here](https://github.com/search?q=repo%3Adropbox%2FPyHive%20async_&type=code).
Are you using a different DB-API to connect to Hive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
