bkyryliuk commented on code in PR #24984:
URL: https://github.com/apache/superset/pull/24984#discussion_r1303380504
##########
superset/db_engine_specs/hive.py:
##########
@@ -542,11 +542,9 @@ def update_impersonation_config(
connect_args["configuration"] = configuration
@staticmethod
- def execute( # type: ignore
- cursor, query: str, async_: bool = False
- ): # pylint: disable=arguments-differ
- kwargs = {"async": async_}
- cursor.execute(query, **kwargs)
+ def execute(cursor, query: str):
Review Comment:
hm, `databricks://token` - that should not be using pyhive but rather native
databricks sqlalchemy adapter.
I haven't had a time to debug this issue and we may get to it in a couple
weeks
cc @zhaorui2022
consider flagging this to
https://github.com/databricks/databricks-sql-python as well, I think it is
coming from databricks connector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
