justinpark opened a new pull request, #25133:
URL: https://github.com/apache/superset/pull/25133

   ### SUMMARY
   Fixes #24790
   
   Since /updated_since api migrate to v1 in #22611 , the startDttm format has 
been changed from a number to a string.
   
   |api/v1|legacy api|
   |--|--|
   
|![Superset](https://github.com/apache/superset/assets/1392866/0cad38ed-34bd-4b19-8502-2a1798774962)|![superset-dev_-_Airbnb_-_Slack](https://github.com/apache/superset/assets/1392866/58553b81-c9a3-4b62-98b7-e48d6eab84dd)|
   
   Similar to #19605, it fails the conversion to a moment object. Since the 
Flask’s JSON serialization of decimals casts it to a string is actually correct 
as it preserves precision, so the frontend should expect strings.
   This commit adds the extra json-bigint parse logic to handle the floating 
value in the string format.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   After:
   
   
https://user-images.githubusercontent.com/1392866/264449407-c2015fe7-d1ef-48b4-9c98-60de6aa27c9c.png
   
   Before:
   
   
https://user-images.githubusercontent.com/57723564/255794908-2b4a9005-00fc-4adc-95b0-d7a8a0fdee09.png
   
   ### TESTING INSTRUCTIONS
   Go to SQLLab and run a query
   Go to Query history and check the start date column
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to