john-bodley commented on code in PR #25133:
URL: https://github.com/apache/superset/pull/25133#discussion_r1310860737
##########
superset-frontend/packages/superset-ui-core/src/connection/callApi/parseResponse.ts:
##########
@@ -56,7 +56,10 @@ export default async function parseResponse<T extends
ParseMethod = 'json'>(
// `json-bigint` could not handle floats well, see
sidorares/json-bigint#62
// TODO: clean up after json-bigint>1.0.1 is released
json: cloneDeepWith(json, (value: any) =>
- value?.isInteger?.() === false ? Number(value) : undefined,
+ value?.isInteger?.() === false ||
Review Comment:
@justinpark how is there any merit to casting this to a
[Decimal](https://mikemcl.github.io/decimal.js/) as opposed to a `Number` or
are these types typically not used by the Superset frontend?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
