sebastianliebscher opened a new pull request, #25166: URL: https://github.com/apache/superset/pull/25166
### SUMMARY This PR fixes an incorrect default value for config variable `UPLOAD_FOLDER`: - current `superset/app/static/uploads/` - new `superset/static/uploads/` Additionally: - `superset/static/uploads/` is now checked into git (analog as `superset/static/assets/`) - `superset/static/assets/` was initially checked into git years before, but in another commit (also years before) then .gitignored without removal from git (I think unintentionally) This checks both directories into git, thus being empty default directories. Any content will be ignored. ```.gitignore superset/static/assets/* !superset/static/assets/.gitkeep superset/static/uploads/* !superset/static/uploads/.gitkeep ``` The config variables `IMG_UPLOAD_FOLDER` and `IMG_UPLOAD_URL` were never used (found nothing using full text search). ### TESTING INSTRUCTIONS - unit + integrations tests - `docker build . -t test` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
