sebastianliebscher commented on code in PR #25166:
URL: https://github.com/apache/superset/pull/25166#discussion_r1313714046


##########
.gitignore:
##########
@@ -50,22 +50,23 @@ env
 venv*
 env_py3
 envpy3
-env36
 local_config.py
 /superset_config.py
 /superset_text.yml
 superset.egg-info/
 superset/bin/supersetc
 tmp
 rat-results.txt
-superset/app/
 
 # Node.js, webpack artifacts, storybook
 *.entry.js
 *.js.map
 node_modules
 npm-debug.log*
-superset/static/assets
+superset/static/assets/*
+!superset/static/assets/.gitkeep
+superset/static/uploads/*
+!superset/static/uploads/.gitkeep

Review Comment:
   This checks both directories into git, thus being empty default directories. 
Any content will be ignored.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to