zhaoyongjie commented on code in PR #25126:
URL: https://github.com/apache/superset/pull/25126#discussion_r1336045348
##########
superset/common/query_context_factory.py:
##########
@@ -128,6 +128,8 @@ def _apply_granularity(
if granularity := query_object.granularity:
filter_to_remove = None
+ if is_adhoc_column(x_axis): # type: ignore
Review Comment:
@zephyring @villebro I think this PR introduced another potential bug in
Adhoc column as X-Axis, you should sent a probe query to ensure x-axis is a
temporal column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
