geido commented on PR #25151: URL: https://github.com/apache/superset/pull/25151#issuecomment-1744820141
@justinpark code LGTM. Not sure if all of these are related, actually this might all be unrelated, but for reference here is what I found from manual testing and messing up with SQL Lab 1. The duplicate tab does not recognize tab name and goes with "Untitled". Also, when going back to previous tab the result set is emptied https://github.com/apache/superset/assets/60598000/26d873f1-54cb-452e-8415-682eab80f4cb 2. When from saved queries to SQL Lab but the menu is still highlighting Saved Queries. Same happens with query history  3. Again, this is probably unrelated but when I have multiple tabs, if I select "Query History" in one tab it will move all the other tabs to "Query History". I think this is related to the video above. For instance, if I am viewing the definition of a table and then switch to a different query it will go empty and it will make the table definition disappear in the originating tab https://github.com/apache/superset/assets/60598000/f8f908cc-f927-40bd-878e-c83a27d0caae 4. Not sure how this is happening but I found queries in Query history with no title, which will correspond to a tab named "Copy of" in SQL Lab. 5. Found that you can name a query with an empty space (100% unrelated) 6. I saw that we lost the ability to forcefully open the query in a new browser tab from Explore -> Run in SQL Lab. I think the user should still be able to choose whether to open it in a new browser tab or not. Same happens in Saved Queries but not in Query History -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
