justinpark commented on PR #25151:
URL: https://github.com/apache/superset/pull/25151#issuecomment-1747279563
> Not sure if all of these are related, actually this might all be
unrelated, but for reference here is what I found from manual testing and
messing up with SQL Lab
>
> 1. The duplicate tab does not recognize tab name and goes with "Untitled".
Also, when going back to previous tab the result set is emptied
This is an existing bug and will follow up in the separate PR.
> Superset.mp4
> 2. Wnet from saved queries to SQL Lab but the menu is still highlighting
Saved Queries. Same happens with query history
>
> 
I think you navigate back/forth by the browser navigation (not menu). This
is same issue on existing tabs (went from Saved Queries to Query History) and
will follow up in the separate PR.
> 3. Again, this is probably unrelated but when I have multiple tabs, if I
select "Query History" in one tab it will move all the other tabs to "Query
History". I think this is related to the video above. For instance, if I am
viewing the definition of a table and then switch to a different query it will
go empty and it will make the table definition disappear in the originating tab
>
This is how SQL Lab designed before (because activeSouthPaneTab not belong
to each tab but belong to the entire sqllab). Should follow up in the separate
PR.
> 4. I found queries in Query history with no title, which will correspond
to a tab named "Copy of" in SQL Lab.
Same as no. 1
> 5. Realized that you can name a query with an empty space (100% unrelated)
This is an existing bug and will follow up in the separate PR.
> 6. I saw that we lost the ability to forcefully open the query in a new
browser tab from Explore -> Run in SQL Lab. I think the user should still be
able to choose whether to open it in a new browser tab or not. Same happens in
Saved Queries but not in Query History
The basically it should support cmd + click that can open the link in a new
browser tab but some links(which you mentioned) require a post data to retrieve
the sql context so hard to maintain in SPA approach. I hope this is not a
blocker of running SPA and want to discuss in the next thread(PR) for the
support of opening new tab.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
