sebastianliebscher commented on PR #25546: URL: https://github.com/apache/superset/pull/25546#issuecomment-1751479161
@sfirke Both, I'm not sure which is the best way to initlialize the Postgres db, without the `docker/docker-entrypoint-initdb.d/examples-init.sh`. I'm thinking of the following possibilities: 1. provide another docker image tag e.g. `superset:examples-db`. the docker-compose-non-dev.yml would get the examples db as its own postgres service like I mentioned here https://github.com/apache/superset/discussions/23399#discussioncomment-6708360 1. move the logic of examples-init.sh into the cli command superset load-examples. for this you would have to detect if the example-db is postgres 1. copy examples-init.sh into the superset-init container and add logic to run the script. to do this you would need to detect if the examples-db is postgres and the superset-init container would also need the postgres-client package I think 3. is not a good idea as it is too much customization. 2. I am not familiar with superset load-examples. I would go for 1. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
