sebastianliebscher commented on PR #25546: URL: https://github.com/apache/superset/pull/25546#issuecomment-1757242085
> Would the pip workflow continue as is, if we make this modification to docker? Yes, the pip workflow still uses SQLite by default. > would we need a whole separate Postgres container for the examples, or just a separate db (and maybe user) in the same Postgres container? Ideally we should just use one Postgres service and have Superset's metadata separated from the examples, yes. This was already achieved and merged by https://github.com/apache/superset/pull/25003. But that requires an initialization script (`examples-init-sh`) to set up the other database and user. To still be able to curl and start just the single `docker-compose-non-dev.yml`, this init script logic has to be removed/moved without losing the separation between metadata and examples. That's what I tried to express with my comment above https://github.com/apache/superset/pull/25546#issuecomment-1751479161. The current solution in this PR uses two separate Postgres services with examples enabled by default. If a user decides not to use examples, it is as easy as deleting the `examples` service + volume and `SUPERSET_LOAD_EXAMPLES` config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
