ggam opened a new pull request, #25734: URL: https://github.com/apache/superset/pull/25734
### SUMMARY Fixes https://github.com/apache/superset/issues/25675 enabling word wrap on text editor and unfixing modal height (previously 350px). Note that this enabled word wrap everywhere. I could change it to only apply to the Edit Dataset modal, but I think it makes sense to have this consistently enabled so we can see the most of the SQL expressions, even if it's not manually formatted (adding newlines). ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before, see SQL Expression:  After, with word wrap enabled:  Before, Table height fixed to 350px, only 6 rows are shown on my 1920x1080 screen:  After unfixing the heigth:  Smaller screens are not affected as I only change the fixed `height` to `min-height`. ### TESTING INSTRUCTIONS Edit any dataset, can be from the examples. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [X] Has associated issue: https://github.com/apache/superset/issues/25675 - [ ] Required feature flags: - [X] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
