kasiazjc commented on PR #25734: URL: https://github.com/apache/superset/pull/25734#issuecomment-1833953865
> Ping @michael-s-molina @kgabryje @kasiazjc would you please review this PR? Hi and sorry for the long wait! I think the changes make sense and I mostly agree with them. Question about the height - will it always fill the screen or depends on the content? I am a designer, so not sure how some of the properties do work Also thanks @michael-s-molina for tagging me and keeping tabs on the changes 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
