michael-s-molina commented on code in PR #26151:
URL: https://github.com/apache/superset/pull/26151#discussion_r1431883264
##########
superset-frontend/packages/superset-ui-chart-controls/src/constants.ts:
##########
@@ -24,7 +24,12 @@ import {
QueryColumn,
DatasourceType,
} from '@superset-ui/core';
-import { ColumnMeta, SortSeriesData, SortSeriesType } from './types';
+import {
+ BootstrapData,
+ ColumnMeta,
+ SortSeriesData,
+ SortSeriesType,
+} from './types';
Review Comment:
```suggestion
import { ColumnMeta, SortSeriesData, SortSeriesType } from './types';
```
##########
superset-frontend/packages/superset-ui-chart-controls/src/types.ts:
##########
@@ -557,3 +557,10 @@ export type ControlFormItemSpec<T extends ControlType =
ControlType> = {
defaultValue?: Currency;
}
: {});
+
+interface CommonBootstrapData {
+ conf: JsonObject;
+}
+export interface BootstrapData {
+ common: CommonBootstrapData;
+}
Review Comment:
```suggestion
```
##########
superset-frontend/packages/superset-ui-chart-controls/src/constants.ts:
##########
@@ -75,3 +80,9 @@ export const DEFAULT_XAXIS_SORT_SERIES_DATA: SortSeriesData =
{
sort_series_type: SortSeriesType.Name,
sort_series_ascending: true,
};
+
+export const DEFAULT_BOOTSTRAP_DATA: BootstrapData = {
+ common: {
+ conf: {},
+ },
+};
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
