jessie-ross commented on code in PR #26391: URL: https://github.com/apache/superset/pull/26391#discussion_r1440109990
########## superset-frontend/src/pages/ExportGoogleSheets/index.tsx: ########## @@ -0,0 +1,76 @@ +/** Review Comment: > I guess I could do this in the front-end with toasts actually, that would be a viable alternative to me. After experimenting with this I've found that Superset navigation can unintuitively trigger a full page reload, e.g. navigating from "SQL Lab" to "Datasets", meaning that the front-end export process would be lost. This could be mitigated by a prevent-navigate-away alert, but I don't think that would be preferable UX, and we're heading further away from simplicity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
