jessie-ross commented on code in PR #26391: URL: https://github.com/apache/superset/pull/26391#discussion_r1440104082
########## superset-frontend/src/pages/ExportGoogleSheets/index.tsx: ########## @@ -0,0 +1,76 @@ +/** Review Comment: My reasoning is that using an separate page provides a better user experience, and helps decouple the code. It prevents popup blocker issues, but more importantly, this process can take some time, especially as the backend might need to rerun a query for export: https://github.com/apache/superset/blob/9033e72679fad7efdabc0f5b28607d974a7b5e1f/superset/commands/sql_lab/export.py?plain=1#L112-L126 Our databases (SparkSQL mainly) are particularly slow, and then adding on top of that expensive queries and large amounts of data that need to be moved, we're looking at a 1m average wait time, with the upper bounds being around 15m. By having this process occur on a separate page it allows the export to happen asynchronously, and for the user to continue their use of Superset while the export occurs. Notably the CSV export already behaves like this - the download starts asynchronously to the UI. Simple alternatives would be a modal, or hover popup, suffering from the long loading time issue. A more complex alternative would be to perform the export on the backend, and provide a notification to the user when it's done. I'm not sure if Superset has this kind of thing set up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
