Khrol commented on code in PR #26355:
URL: https://github.com/apache/superset/pull/26355#discussion_r1446089512


##########
tests/integration_tests/databases/api_tests.py:
##########
@@ -1340,6 +1340,22 @@ def test_get_invalid_table_table_extra_metadata(self):
         self.assertEqual(rv.status_code, 200)
         self.assertEqual(data, {})
 
+    def test_get_invalid_table_table_extra_metadata_trino(self):

Review Comment:
   @john-bodley, I'm not sure if this is the best place to test this behavior. 
   At the same time, testing in `tests/integration_tests/db_engine_specs` is 
quite useless too because everything is mocked and there is no Trino connection.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to