Khrol opened a new pull request, #26355: URL: https://github.com/apache/superset/pull/26355
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> SQLAlchemy doesn't strictly define what `get_indexes` method should do when table is not found. Some dialects return the empty list while some of them raise `NoSuchTableError`. When `NoSuchTableError` error is thrown, API returns 500 when non-existing table details are requested. This PR fixes this issue and returns 404 in such cases. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Paste some non-existing table name in table name field and hit Enter: <img width="415" alt="Screenshot 2023-12-25 at 18 05 06" src="https://github.com/apache/superset/assets/3982146/b9c6fa72-32f1-4fab-a1d9-e813ab72eaee";> Expected: no 500 errors from the backend. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
