kgabryje commented on PR #26439:
URL: https://github.com/apache/superset/pull/26439#issuecomment-1887032957
I think this change will break things when `GENERIC_CHART_AXES` is disabled.
AFAIK the goal of that check was not to display time column and time range
fields, as in most charts those 2 were used only for filtering, and we moved
the filtering capability to adhoc filters.
The problem is that some charts, like Calendar or Event flow, require a time
column to be defined for other purposes than just filtering. I think we should
treat those cases individually, like it was done for Calendar chart's control
panel.
In the case of Event flow chart, we could replace
`sections.legacyRegularTime` with `{
...baseTimeSection,
controlSetRows: [['granularity_sqla'], ['time_range']],
}`
to make the time section independent of `GENERIC_CHART_AXES` feature flag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
