villebro commented on PR #26439:
URL: https://github.com/apache/superset/pull/26439#issuecomment-1887736065

   @michael-s-molina @kgabryje I did some more checking, and I misremembered 
how the generic chart x-axis charts import handle the time section. Sorry for 
the noisy escalation - It seems the majority of legacy charts work fine with 
the new time filter (=that essentially replaces the old time section), and no 
longer need the dedicated time section.
   
   However, I noticed, that at least the t-test chart is also no longer 
functioning with generic chart axes turned on. To DRY this up, we may want to 
consider creating a shared control that always has the time section, but if 
it's only event flow and t-test at this point, then maybe it's not worth the 
effort.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to