justinpark commented on code in PR #26602:
URL: https://github.com/apache/superset/pull/26602#discussion_r1456523063
##########
superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx:
##########
@@ -478,6 +478,7 @@ const Selector: React.FC<{
key={selector}
name={selector}
className={cx(className, isSelected && 'selected')}
+ role="button"
Review Comment:
Since SelectorLabel is a button element, role is not necessary (implicitly
defined) but type is necessary for a11y POV.
```suggestion
type="button"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
