eulloa10 opened a new pull request, #26602: URL: https://github.com/apache/superset/pull/26602
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Clickable UI elements lacking `<a>` or `<button>` tags, or the `role="button"` attribute, weren't semantically clear as clickable elements when using a screen reader. To improve accessibility, I reviewed the React codebase for `onClick` handlers. When encountering HTML elements with `onClick` handlers AND without `<a>` or `<button>` tags, I added the `role="button"` attribute to identify them as clickable. This approach targets the most immediate and straightforward cases, ensuring that elements triggered by onClick handlers are now clearly identified as clickable for users relying on screen readers. ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Testing options include: - Using a screen reader: identify and navigate through the clickable components and ensure they are announced correctly - Using browser devtools: inspect clickable elements and verify that elements without `<a>` or `<button>` tags have the `role="button"` attribute. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #26190 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
