mistercrunch commented on code in PR #26698:
URL: https://github.com/apache/superset/pull/26698#discussion_r1462568400
##########
Dockerfile:
##########
@@ -85,14 +85,15 @@ RUN
--mount=type=bind,target=./requirements/local.txt,src=./requirements/local.t
--mount=type=cache,target=/root/.cache/pip \
pip install -r requirements/local.txt
-COPY --chown=superset:superset --from=superset-node
/app/superset/static/assets superset/static/assets
-## Lastly, let's install superset itself
-COPY --chown=superset:superset superset superset
RUN --mount=type=cache,target=/root/.cache/pip \
pip install -e . \
&& flask fab babel-compile --target superset/translations \
&& chown -R superset:superset superset/translations
+COPY --chown=superset:superset --from=superset-node
/app/superset/static/assets superset/static/assets
Review Comment:
I think moving this AFTER the `pip install` command is going to be a huge
win. Currently if you touch any JS file you'll have to re-pip install
everything, where now it shouldn't be the case anymore. Frontend PRs/SHAs won't
have to import and rebuild the backend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
