dpgaspar commented on PR #26698: URL: https://github.com/apache/superset/pull/26698#issuecomment-1905591861
> > Request for comments here, given this docker build matrix: > > ```yaml > > strategy: > > matrix: > > target: ["dev", "lean", "lean310", "lean39", "websocket", "dockerize"] > > platform: ["linux/amd64", "linux/arm64"] > > fail-fast: false > > ``` > > > > > > > > > > > > > > > > > > > > > > > > Do we need every combination for each PR and each SHA in `master`? Seems a bit crazy. I get that people are on Apple hardware and that's why we need `arm` as a base platform, but 2 versions of python too? @craig-rueda @rusackas @dpgaspar > > We can probably remove lean39. I added that version as a request from someone in the community who later found a workaround, and it's probably not needed. We can maybe check with @rusackas on data around who is using it, but I don't think we really need to have docker images based on multiple versions of python. I may be missing some requirements, but totally agree, I actually don't see the point on building every flavour on every PR SHA, also on a PR from a fork, images are just built and not pushed so we are just testing them. My take would be to just leave `lean, linux/amd64` and `websocket, linux/amd64` on every PR SHA, so be enough for testing purposes. Build push all of them when merging to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
