kasiazjc commented on PR #26699: URL: https://github.com/apache/superset/pull/26699#issuecomment-1919047558
> @justinpark this looks and feels so much better! definitely a much needed improvement :) > > A few things I noticed: > > 1. When adding tabs to a dashboard, the drop area extends a bit too far, into the right panel >  > 2. When adding a chart element, the dashboard header row is also highlighted as a possible drop area > 3. I managed to get an error when dragging a chart in between the header and the dashboard area somewhere, but I can't figure out how to repro it :( > > <img alt="image" width="1148" src="https://private-user-images.githubusercontent.com/10627051/301000116-ae9a9762-8110-404f-8266-1b869c961aac.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDY3MDU2NzEsIm5iZiI6MTcwNjcwNTM3MSwicGF0aCI6Ii8xMDYyNzA1MS8zMDEwMDAxMTYtYWU5YTk3NjItODExMC00MDRmLTgyNjYtMWI4NjljOTYxYWFjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMzElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTMxVDEyNDkzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE4YjQyNGU2MzlmZWY0M2IwNDIyYjE1NDNmZmQ1MWM0OGNkOTdkMDUxNGU0N2ZkNTUwMWZkZGY2ZjVlYjU1OTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.l-_EgJudDU0G_xJ5IemQxBNs-riqxHIDIGUVKdDcdyA";> agree with Sophie on all of the above! Definitely an improvement to the dnd, thank you @justinpark ☺️ one comment about the header thing Sophie mentioned: when you try to hover over it it shows a red box (error), which gave me an idea. I think maybe it could be used in places where there is not enough space to place the item, for example if the row is full. What do you think? <img width="1792" alt="image" src="https://github.com/apache/superset/assets/36897697/8cf51e10-3eb2-46e2-99c2-11723a9c8153";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://private-user-images.githubusercontent.com/10627051/301000116-ae9a9762-8110-404f-8266-1b869c961aac.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDY3MDU2NzEsIm5iZiI6MTcwNjcwNTM3MSwicGF0aCI6Ii8xMDYyNzA1MS8zMDEwMDAxMTYtYWU5YTk3NjItODExMC00MDRmLTgyNjYtMWI4NjljOTYxYWFjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMzElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTMxVDEyNDkzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE4YjQyNGU2MzlmZWY0M2IwNDIyYjE1NDNmZmQ1MWM0OGNkOTdkMDUxNGU0N2ZkNTUwMWZkZGY2ZjVlYjU1OTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.l-_EgJudDU0G_xJ5IemQxBNs-riqxHIDIGUVKdDcdyA"](https://private-user-images.githubusercontent.com/10627051/301000116-ae9a9762-8110-404f-8266-1b869c961aac.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDY3MDU2NzEsIm5iZiI6MTcwNjcwNTM3MSwicGF0aCI6Ii8xMDYyNzA1MS8zMDEwMDAxMTYtYWU5YTk3NjItODExMC00MDRmLTgyNjYtMWI4NjljOTYxYWFjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMzElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTMxVDEyNDkzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE4YjQyNGU2MzlmZWY0M2IwNDIyYjE1NDNmZmQ1MWM0OGNkOTdkMDUxNGU0N2ZkNTUwMWZkZGY2ZjVlYjU1OTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.l-_EgJudDU0G_xJ5IemQxBNs-riqxHIDIGUVKdDcdyA"){kind=link}