jseparovic commented on PR #26736: URL: https://github.com/apache/superset/pull/26736#issuecomment-1925585963
@justinpark Thanks for the review! I updated the PR to use useMemo as per your suggestion, but unfortunately it broke the fix for when the plots do not load until the map is dragged. The latest commit I pushed shows the working code where i added `// ++` comments for the added lines and `// --` for the removed lines so you can see what the code looked like with useMemo. Any ideas on how to fix this bug with useMemo? Essentially the issue is that when the map loaded for the first time after logging in, it works ok, but then if you go back to that dashboard, or refresh the page, the plots do not load until you drag the map. The useEffect+useState fixes this, but the useMemo does not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
