eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1482165415
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts:
##########
@@ -249,9 +249,13 @@ describe('Drill to detail modal', () => {
it('opens the modal with the correct filters', () => {
interceptSamples();
+ // focus on table first to trigger browser scroll
+ cy.get("[data-test-viz-type='table']").contains('boy').rightclick();
+
+ cy.wait(500);
Review Comment:
Yeah this was really tricky because the browser scrolls automatically on
focus, and then the field goes under the header and the right click doesn't
work. I adjusted for this behavior for real users in the onFocus below but for
automations, the wait was the only way to get the browser to catch up. But,
that said, there are a few waits earlier in this script that I think we can
change to timeouts/assert.is.visible, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
