eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1482171039


##########
superset-frontend/src/dashboard/styles.ts:
##########
@@ -97,3 +111,43 @@ export const chartContextMenuStyles = (theme: 
SupersetTheme) => css`
     min-width: ${theme.gridUnit * 40}px;
   }
 `;
+
+export const focusStyle = (theme: SupersetTheme) => css`
+  a,
+  .ant-tabs-tabpane,
+  .ant-tabs-tab-btn,
+  .superset-button.action-button,
+  .superset-button.ant-dropdown-trigger,
+  .header-controls span {
+    &:focus-visible {
+      box-shadow: 0 0 0 2px ${theme.colors.primary.dark1};
+      border-radius: ${theme.gridUnit / 2}px;
+      outline: none;
+      text-decoration: none;
+    }
+    &:not(.superset-button, .ant-menu-item
+        a, .fave-unfave-icon, .ant-tabs-tabpane, .header-controls span) {
+      &:focus-visible {
+        padding: ${theme.gridUnit / 2}px;
+      }
+    }
+  }
+
+  @keyframes fadeOut {

Review Comment:
   Oh, actually, I don't think I need this any more, since I found 
focus-visible. This was just for users that clicked with a mouse. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to