mistercrunch commented on code in PR #26602:
URL: https://github.com/apache/superset/pull/26602#discussion_r1482171641
##########
superset-frontend/src/dashboard/components/menu/DownloadMenuItems/DownloadAsPdf.tsx:
##########
@@ -29,7 +29,7 @@ export default function DownloadAsPdf({
return (
<Menu.Item key="download-pdf" {...rest}>
- <div onClick={onDownloadPdf} role="button" tabIndex={0}>
+ <div role="button" onClick={onDownloadPdf} tabIndex={0}>
Review Comment:
Wondering if we can just bring the onClick and tabIndex to the parent
(Menu.Item) and get rid of that child `<div>` altogether here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
