craig-rueda commented on code in PR #27163:
URL: https://github.com/apache/superset/pull/27163#discussion_r1496088755
##########
helm/superset/values.yaml:
##########
@@ -248,6 +248,8 @@ supersetNode:
maxReplicas: 100
targetCPUUtilizationPercentage: 80
# targetMemoryUtilizationPercentage: 80
+ # -- Sets the [pod disruption
budget](https://kubernetes.io/docs/tasks/run-application/configure-pdb/) for
supersetNode pods
Review Comment:
Can you add an `enabled` field here, along with a set of sensible defaults
for each of these blocks? That way, we can add the various settings to the
schema and can document them appropriately. Using an `enabled` also makes the
config a bit more explicit
e.g.
```yaml
podDisruptionBudget:
enabled: false
minAvailable: 1
maxUnavailable: 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
