craig-rueda commented on code in PR #27163:
URL: https://github.com/apache/superset/pull/27163#discussion_r1496181439
##########
helm/superset/values.yaml:
##########
@@ -248,6 +248,8 @@ supersetNode:
maxReplicas: 100
targetCPUUtilizationPercentage: 80
# targetMemoryUtilizationPercentage: 80
+ # -- Sets the [pod disruption
budget](https://kubernetes.io/docs/tasks/run-application/configure-pdb/) for
supersetNode pods
Review Comment:
Yep, that makes sense. For extra credit, you could fail if both are set:
```helm
{{- if .Values.podDisruptionBudget.minAvailable and
.Values.podDisruptionBudget.maxAvailable }}
{{ required "Only one of minAvailable or maxAvailable should be set"
.Values.podDisruptionBudget.minAvailable }}
{{- end}}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
