zhaoyongjie commented on PR #27145: URL: https://github.com/apache/superset/pull/27145#issuecomment-1955195508
> > btw, I also believe that we should establish a consistent design for this system and "retire" the legacy field in the `query_object` as soon as possible. > > Yeah, if using `DATEADD` is doable I see no need to keep using the `time_shift` field 🙏 The time_offsets is designed for this use case in query_object. <img width="539" alt="image" src="https://github.com/apache/superset/assets/2016594/d0248e38-b186-4a88-b2cb-213ce9f5c98d";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
