zhaoyongjie commented on PR #27145: URL: https://github.com/apache/superset/pull/27145#issuecomment-1956546849
> > With this approach we: > > 1. don't duplicate logic in frontend and we're in total control over when the `DATEADD` is applied > 2. Do not make use of legacy `time_shift` > 3. We don't make use of `time_offsets` which again is tied to time grains, x axis columns etc Sorry,..... I didn't quite catch that since lack of full context, but I think this is an experimental plugin and hidden in the FF, all the frontend changes should be safe. If we simply avoid using legacy config and avoid from introducing too much complexity on the backend, this PR should be fine. Thanks again for the explanation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
