john-bodley commented on code in PR #27554:
URL: https://github.com/apache/superset/pull/27554#discussion_r1536269772
##########
superset/reports/schemas.py:
##########
@@ -320,7 +320,7 @@ class ReportSchedulePutSchema(Schema):
log_retention = fields.Integer(
metadata={"description": log_retention_description, "example": 90},
required=False,
- validate=[Range(min=1, error=_("Value must be greater than 0"))],
+ validate=[Range(min=0, error=_("Value must be 0 or greater"))],
Review Comment:
What does a log retention of `0` mean and how does this differ from `None`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
