rtexelm commented on code in PR #27593:
URL: https://github.com/apache/superset/pull/27593#discussion_r1536459574
##########
superset-frontend/src/dashboard/components/menu/HoverMenu.tsx:
##########
@@ -81,6 +82,8 @@ export default class HoverMenu extends
React.PureComponent<HoverMenuProps> {
position === 'left' && 'hover-menu--left',
position === 'top' && 'hover-menu--top',
)}
+ onMouseEnter={onHover}
+ onMouseLeave={onHover}
Review Comment:
@eschutho Yikes, after an extensive rabbit hole it looks like there isn't
really a great way of using a ref to update the state of `Row` based on hovered
state of `HoverMenu` without a context provider. I'm thinking a callback is the
better choice here but just in case, I made a commit with my attempt at
handling things with a ref.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
