eschutho commented on code in PR #27593:
URL: https://github.com/apache/superset/pull/27593#discussion_r1539738046
##########
superset-frontend/src/dashboard/components/menu/HoverMenu.tsx:
##########
@@ -70,6 +72,18 @@ export default class HoverMenu extends
React.PureComponent<HoverMenuProps> {
children: null,
};
+ handleMouseEnter = () => {
+ if (this.props.onHover) {
+ this.props.onHover(true);
+ }
+ };
+
+ handleMouseLeave = () => {
+ if (this.props.onHover) {
+ this.props.onHover(false);
Review Comment:
This looks great. Another small nit, I'd suggest being more explicit when
defining this onHover function above. When calling it here, there's no context
about what this boolean means. If possible, I usually like to pass a dictionary
instead of a boolean argument, so `this.props.onHover({isHovered:false})` for
example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
