justinpark opened a new pull request, #27717: URL: https://github.com/apache/superset/pull/27717
### SUMMARY In situations where adhoc metrics are enabled, it is reasonable to display all metrics and columns in the adhoc metrics/filters. However, due to the `disallow_adhoc_metrics` setting, not all metrics can be accepted in the dropzone. Consequently, there may be certain items that cannot be accepted in all filters. To address this, the commit takes a step forward by checking the eligibility of each filter and hiding the item when there are no eligible filters available, especially when `disallow_adhoc_metrics` setting is enabled. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: https://github.com/apache/superset/assets/1392866/3d3e6b92-c461-49ba-ad24-f23528acf22c After: https://github.com/apache/superset/assets/1392866/7bc72d2d-f9b8-4603-b607-926c49af9004 ### TESTING INSTRUCTIONS - Set a dataset extra option with `{ "disallow_adhoc_metrics" : true }` - Create a table chart with the dataset - Switch to "Raw Records" and then "Metrics" should be hidden ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
