michael-s-molina opened a new pull request, #27950:
URL: https://github.com/apache/superset/pull/27950

   ### SUMMARY
   This PR adds a new ECharts tooltip renderer with the following objectives:
   - Add the ability to display total and percentage values for our ECharts 
tooltips. This improvement will also allow us to migrate legacy timeseries 
charts which currently display that information.
   - Standardize the way we display tooltips. Currently, every plugin displays 
tooltips using different information and designs, which decreases the overall 
user experience. By creating a reusable renderer, we can ensure consistency 
across plugins.
   - Reduce code duplication.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <img width="1089" alt="Screenshot 2024-04-09 at 10 40 12" 
src="https://github.com/apache/superset/assets/70410625/240f6a10-1981-4b70-96a7-6eb19f6941f6";>
   <img width="1021" alt="Screenshot 2024-04-09 at 09 27 11" 
src="https://github.com/apache/superset/assets/70410625/7fe007df-4ab6-46b0-b183-39d99d49be66";>
   <img width="1115" alt="Screenshot 2024-04-09 at 10 38 21" 
src="https://github.com/apache/superset/assets/70410625/6e50848b-f7c9-46b2-89ae-d2f11ebe55ea";>
   <img width="1051" alt="Screenshot 2024-04-09 at 10 21 59" 
src="https://github.com/apache/superset/assets/70410625/c7fb05ab-752d-4980-a5fd-3090087b1937";>
   <img width="1086" alt="Screenshot 2024-04-09 at 10 42 09" 
src="https://github.com/apache/superset/assets/70410625/5efd3c10-bf2b-4385-a669-785e6f18772c";>
   <img width="1014" alt="Screenshot 2024-04-09 at 09 37 36" 
src="https://github.com/apache/superset/assets/70410625/48e3a216-ffe7-4398-883b-3aa60ae44dc1";>
   
   ### TESTING INSTRUCTIONS
   Test consists in checking how the tooltip is displayed for all ECharts 
plugins and their different control combinations.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to