kgabryje commented on PR #27995: URL: https://github.com/apache/superset/pull/27995#issuecomment-2051848575
> * Selected items are always sorted first. How will that work with groups? Good question. Currently I left it unsorted, but I was thinking about sorting the selected within the groups. The groups remain in their initial positions. > * We allow new items. Where will they be placed? New items do not belong to any group - they will be treated as regular (ungrouped) options > * What's the interaction with Select All? It simply selects all options > > Have we considered implementing this outside of the Select component? Like a radio group that changes the values of the Select depending on the option that is selected? > > If we are thinking specifically about color palettes where new values and select all are disabled, maybe this should be a specific component? > > If you ask me, given the complexity involved, I would implement this with a combination of radio group + Select. The option groups are supported by the native Antd Select, so in my opinion we should also support them in our customised Select. Right now the color scheme picker is our only use case for the groups, but I feel like grouping the options in categories is not such an uncommon thing to do and the need for it might pop up in the future -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
