kgabryje commented on PR #27995: URL: https://github.com/apache/superset/pull/27995#issuecomment-2051935402
> If there's no alternative, and we really need to implement this behavior, then we need to think about how to break the select component because I don't how this behavior will work with: > > > * Selected items are always sorted first. How will that work with groups? > > * We allow new items. Where will they be placed? > > * What's the interaction with Select All? Ugh sorry, I answered those questions in my first response but messed up the formatting 🤦 Pasting it here again: > * Selected items are always sorted first. How will that work with groups? Good question. Currently I left it unsorted, but I was thinking about sorting the selected within the groups. The groups remain in their initial positions. > * We allow new items. Where will they be placed? New items do not belong to any group - they will be treated as regular (ungrouped) options > * What's the interaction with Select All? It simply selects all options -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
