mistercrunch commented on code in PR #27998: URL: https://github.com/apache/superset/pull/27998#discussion_r1566327391
########## README.md: ########## @@ -70,8 +70,8 @@ Superset provides: ## Screenshots & Gifs **Video Overview** - -https://github.com/apache/superset-site/raw/lfs/superset-video-4k.mp4 +<!-- File hosted here https://github.com/apache/superset-site/raw/lfs/superset-video-4k.mp4 --> Review Comment: I'm not sure if it matters where it lives, currently there's no coupling between the CDN (effectively githubusercontent.com) and the location in the repo. In some ways it's just a backup. I don't think anyone would ever edit this file, maybe there's another file format with the source of the different clips/transitions/audio somewhere we could put in source control, but really this asset is probably fine in a CDN + backed in any location where it could be restored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
