mistercrunch commented on code in PR #27998: URL: https://github.com/apache/superset/pull/27998#discussion_r1567606285
########## README.md: ########## @@ -70,8 +70,8 @@ Superset provides: ## Screenshots & Gifs **Video Overview** - -https://github.com/apache/superset-site/raw/lfs/superset-video-4k.mp4 +<!-- File hosted here https://github.com/apache/superset-site/raw/lfs/superset-video-4k.mp4 --> Review Comment: Oh actually I think we don't need to change anything else. Videos only serve from the CDN, and the CDN is de-coupled from the repos. When you drag-n-drop a picture or a video in an issue comment, it'll upload to the CDN and serve in perpetuity as AFAIU. The move to the branch is just a backup in case. I haven't tried but I'm pretty sure if I re-upload the same file to the CDN it may have the same url it it's smart. They don't need to store the same binary twice, guessing the address is based on a hash of some kind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
