john-bodley commented on code in PR #28159:
URL: https://github.com/apache/superset/pull/28159#discussion_r1573340720


##########
tests/integration_tests/charts/api_tests.py:
##########
@@ -83,120 +83,114 @@ class TestChartApi(ApiOwnersTestCaseMixin, 
InsertChartMixin, SupersetTestCase):
 
     @pytest.fixture(autouse=True)
     def clear_data_cache(self):
-        with app.app_context():

Review Comment:
   The app context is not needed within the confines of a derived Flask-Testing 
class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to