john-bodley commented on code in PR #28159: URL: https://github.com/apache/superset/pull/28159#discussion_r1573384862
########## tests/integration_tests/fixtures/public_role.py: ########## @@ -21,24 +21,24 @@ @pytest.fixture() +@pytest.mark.usefixtures("app_context") Review Comment: Reuse existing fixture where possible. ########## tests/integration_tests/fixtures/users.py: ########## @@ -23,27 +23,25 @@ @pytest.fixture() +@pytest.mark.usefixtures("app_context") Review Comment: Reuse existing fixture where possible. ########## tests/integration_tests/fixtures/tags.py: ########## @@ -22,12 +22,12 @@ @pytest.fixture +@pytest.mark.usefixtures("app_context") Review Comment: Reuse existing fixture where possible. ########## tests/integration_tests/fixtures/datasource.py: ########## @@ -173,39 +173,38 @@ def get_datasource_post() -> dict[str, Any]: @pytest.fixture() +@pytest.mark.usefixtures("app_conntext") Review Comment: Reuse existing fixture where possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org