betodealmeida commented on code in PR #28159:
URL: https://github.com/apache/superset/pull/28159#discussion_r1575165854
##########
tests/integration_tests/migrations/87d38ad83218_migrate_can_view_and_drill_permission__tests.py:
##########
@@ -34,28 +36,28 @@
downgrade = migration_module.do_downgrade
+@pytest.mark.usefixtures("app_context")
Review Comment:
Same here, should we standardize on either using `usefixtures` or passing
`app_context` to the test function/fixture?
##########
tests/integration_tests/fixtures/tags.py:
##########
@@ -22,12 +22,12 @@
@pytest.fixture
+@pytest.mark.usefixtures("app_context")
Review Comment:
Why not pass `app_context` as an argument, like in other places, for
consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
