john-bodley commented on code in PR #28159:
URL: https://github.com/apache/superset/pull/28159#discussion_r1573399317
##########
tests/integration_tests/conftest.py:
##########
@@ -118,8 +118,8 @@ def _get_user(username: str) -> ab_models.User:
@pytest.fixture(autouse=True, scope="session")
def setup_sample_data() -> Any:
# TODO(john-bodley): Determine a cleaner way of setting up the sample data
without
- # relying on `tests.integration_tests.test_app.app` leveraging an `app`
fixture which is purposely
- # scoped to the function level to ensure tests remain idempotent.
+ # relying on `tests.integration_tests.test_app.app` leveraging an `app`
fixture
+ # which is purposely scoped to the function level to ensure tests remain
idempotent.
Review Comment:
The existing `app_context` fixture cannot be used due to different scopes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
