1yuv commented on issue #19222:
URL: https://github.com/apache/superset/issues/19222#issuecomment-2077776158

   Hi @rusackas ,  I was able to reproduce this today as well, from 1.3 to 4.0.
   **Steps:**
   1. Export multiple datasets (physical/virtual) from older version, this 
gives you an yaml file. 
   2. Try importing that data sets on 4.0 superset. 
   3. You see an error like this:
   
   <img width="737" alt="image" 
src="https://github.com/apache/superset/assets/6102813/af91105f-f85b-4d4b-97e7-c7e0168ce950";>
   
   <details>
     <summary>View Logs</summary>
   
   ```
   Importing dataset from file 20240425_165955.yaml
   2024-04-25 
17:09:48,511:INFO:superset.commands.dataset.importers.v0:Importing dataset from 
file 20240425_165955.yaml
   Error running import command
   Traceback (most recent call last):
     File "/app/superset/commands/dataset/importers/dispatcher.py", line 57, in 
run
       command.run()
     File "/app/superset/commands/dataset/importers/v0.py", line 255, in run
       params = json.loads(dataset["params"])
   KeyError: 'params'
   2024-04-25 
17:09:48,511:ERROR:superset.commands.dataset.importers.dispatcher:Error running 
import command
   Traceback (most recent call last):
     File "/app/superset/commands/dataset/importers/dispatcher.py", line 57, in 
run
       command.run()
     File "/app/superset/commands/dataset/importers/v0.py", line 255, in run
       params = json.loads(dataset["params"])
   KeyError: 'params'
   'params'
   Traceback (most recent call last):
     File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1823, in 
full_dispatch_request
       rv = self.dispatch_request()
     File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1799, in 
dispatch_request
       return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
     File 
"/usr/local/lib/python3.10/site-packages/flask_appbuilder/security/decorators.py",
 line 95, in wraps
       return f(self, *args, **kwargs)
     File "/app/superset/views/base_api.py", line 127, in wraps
       raise ex
     File "/app/superset/views/base_api.py", line 121, in wraps
       duration, response = time_function(f, self, *args, **kwargs)
     File "/app/superset/utils/core.py", line 1463, in time_function
       response = func(*args, **kwargs)
     File "/app/superset/utils/log.py", line 255, in wrapper
       value = f(*args, **kwargs)
     File "/app/superset/views/base_api.py", line 108, in wraps
       return f(self, *args, **kwargs)
     File "/app/superset/datasets/api.py", line 926, in import_
       command.run()
     File "/app/superset/commands/dataset/importers/dispatcher.py", line 68, in 
run
       raise exc
     File "/app/superset/commands/dataset/importers/dispatcher.py", line 57, in 
run
       command.run()
     File "/app/superset/commands/dataset/importers/v0.py", line 255, in run
       params = json.loads(dataset["params"])
   KeyError: 'params'
   2024-04-25 17:09:48,511:ERROR:superset.views.base:'params'
   Traceback (most recent call last):
     File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1823, in 
full_dispatch_request
       rv = self.dispatch_request()
     File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1799, in 
dispatch_request
       return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
     File 
"/usr/local/lib/python3.10/site-packages/flask_appbuilder/security/decorators.py",
 line 95, in wraps
       return f(self, *args, **kwargs)
     File "/app/superset/views/base_api.py", line 127, in wraps
       raise ex
     File "/app/superset/views/base_api.py", line 121, in wraps
       duration, response = time_function(f, self, *args, **kwargs)
     File "/app/superset/utils/core.py", line 1463, in time_function
       response = func(*args, **kwargs)
     File "/app/superset/utils/log.py", line 255, in wrapper
       value = f(*args, **kwargs)
     File "/app/superset/views/base_api.py", line 108, in wraps
       return f(self, *args, **kwargs)
     File "/app/superset/datasets/api.py", line 926, in import_
       command.run()
     File "/app/superset/commands/dataset/importers/dispatcher.py", line 68, in 
run
       raise exc
     File "/app/superset/commands/dataset/importers/dispatcher.py", line 57, in 
run
       command.run()
     File "/app/superset/commands/dataset/importers/v0.py", line 255, in run
       params = json.loads(dataset["params"])
   KeyError: 'params'
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to